Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra closing parenthesis in code sample #25344

Merged

Conversation

gaelgoth
Copy link
Contributor

Hey, I just made a Pull Request!

Small fix in database test code sample

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@gaelgoth gaelgoth requested review from a team as code owners June 20, 2024 14:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 20, 2024
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaelgoth 👍

Signed-off-by: Gaël Gothuey <gothuey.gael@gmail.com>
Signed-off-by: gaelgoth <gothuey.gael@gmail.com>
@gaelgoth
Copy link
Contributor Author

Fixed format

@gaelgoth gaelgoth force-pushed the doc/fix-extra-closing-parenthesis branch from 98a81ca to 18daa1f Compare June 20, 2024 17:56
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice! 🎉

@benjdlambert benjdlambert merged commit 352438b into backstage:master Jun 25, 2024
21 checks passed
@gaelgoth gaelgoth deleted the doc/fix-extra-closing-parenthesis branch July 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants