Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backstage-cli (templates): update dependencies of the backend plugins #25345

Conversation

axiac
Copy link
Contributor

@axiac axiac commented Jun 20, 2024

Hey, I just made a Pull Request!

The template used by yarn new to create a new backend plugin contains some outdated dependencies.
The changes in this PR:

  • remove unused dependencies winston and yn from the template of backend plugins;
  • use msw v2 on the backend plugins; migrating later from v1 to v2 is not straight forward, it is better to start with v2.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@axiac axiac requested review from a team as code owners June 20, 2024 16:52
@axiac axiac requested review from freben and vinzscam June 20, 2024 16:52
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.26.7

* remove unneeded dependencies `winston` and `yn` from the template
  of backend plugins;
* use `msw` v2 on the backend plugins; migrating later from v1 to v2
  is not straight forward; it is better to start with v2;

Signed-off-by: Valentin VĂLCIU <axiac.ro@gmail.com>
@axiac axiac force-pushed the update-dependencies-in-backend-plugin-template branch from 93cddde to e2e320c Compare June 21, 2024 19:59
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for this, was looking at doing this for the msw package, so nice that you got that covered here too 🙏

@benjdlambert benjdlambert merged commit da38d59 into backstage:master Jun 24, 2024
26 of 27 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.29.0 release, scheduled for Tue, 16 Jul 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants