backend: change the default backend plugin mount point to /api #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freben
reviewed
Sep 23, 2020
packages/create-app/templates/default-app/packages/backend/src/index.ts
Outdated
Show resolved
Hide resolved
|
Should clarify that the primary reason for doing this is to enable deployments where the frontend and backend are hosted on the same origin, as currently e.g. |
freben
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches things to be mounted on
/apiin the backend. This is a bit extra painful because we don't have #1847 in place, so there are a couple of hardcoded routes in some places in the backends.Expecting that as long as all dependencies are bumped in sync, the only breakage is that OAuth redirect URLs need to be reconfigured. It is somewhat possible to keep the existing routing in place, and I added a parameter for that in the auth backend, but there is some new hardcoded usage of
/api.I did investigate creating more of an API around this in the service build from
backend-common, but tbh it just got awkward with ordering of routes, and there's also a pretty minimal of code required anyway. I did also try making the service build do a bit more work in creating new environments, but figured that can be explored more easily after this would have been merged.