Replace implementsApis with providesApis and add consumesApis #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhenneke
reviewed
Nov 25, 2020
Fox32
force-pushed
the
feat/provides-consumse-api
branch
from
fd97080
to
6f70ed7
Compare
freben
approved these changes
Nov 26, 2020
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
🦋 Changeset detectedLatest commit: 032aba5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks, I made the changes. Once this is merged I will prepare the PR that we can merge after Dec 14th |
Fox32
added a commit
to SDA-SE/backstage
that referenced
this pull request
Dec 7, 2020
This was deprecated in backstage#3449. This should not be merged sooner then Dec 14th, 2020!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the new relations are using the term "provides" we should rename it in the spec too.
implementsApisis now calledprovidesApis. In addition, the new fieldconsumesApisis added to fill the new "consumes" relationship.This PR only deprecated the
implementsApisfield for future removal (after Dec 14th, 2020). Please not that code that is not using the relations will not work when only the fieldprovidesApisis filled. Code that is using the new relations will work as before.@freben / @Rugvip what do you think?
Till now, this PR doesn't remove the usage of
implementsApisin the frontend, but I plan to add these changes to this PR too. I wouldn't switch to the new spec properties, but directly to the relations instead (done). In my opinion this would support bothimplementsApisandprovidesApisduring the deprecation phase. Consumers outside of this repository have to make sure that they fill both fields.After deprecation we have to:
✔️ Checklist