Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(msgraph): support advanced querying capabilities #9921

Merged
merged 1 commit into from Mar 14, 2022
Merged

feat(msgraph): support advanced querying capabilities #9921

merged 1 commit into from Mar 14, 2022

Conversation

pjungermann
Copy link
Contributor

Support advanced querying capabilities
using the new config option

queryMode?: 'basic' | 'advanced'

which will set all required headers and
query parameters.

Closes: #9795
Signed-off-by: Patrick Jungermann Patrick.Jungermann@gmail.com

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@pjungermann pjungermann requested a review from a team as a code owner March 2, 2022 19:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2022 •
edited

🦋 Changeset detected

Latest commit: 759b32b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@backstage/plugin-catalog-backend-module-msgraph Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added awaiting-review area:catalog Related to the Catalog Project Area labels Mar 2, 2022
@pjungermann pjungermann force-pushed the PJ_msgraph_advanced-queries branch 3 times, most recently from 0d4dc90 to cd41668 Compare March 3, 2022 13:25
@ehrnst
Copy link
Contributor

ehrnst commented Mar 4, 2022

thanks this is a great addition :)

@pjungermann
Copy link
Contributor Author

@ehrnst feel free to review the changes, too

ehrnst
ehrnst reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ehrnst ehrnst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK with me. Not sure how the review-routine works with Backstage.

@pjungermann
Copy link
Contributor Author

@ehrnst I believe if it looks ok to you, you can leave an approval. Maintainers will have a look, too. But that helps them if there was already another review from the community.

freben
freben reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, let's just update the changeset and then good to go!

.changeset/beige-lamps-cry.md
@@ -0,0 +1,5 @@
---
'@backstage/plugin-catalog-backend-module-msgraph': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be minor since it's a breaking change to a public interface

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean the change to the client.getUsers and client.getGroups functions, right @freben? Besides that queryMode is optional with backwards compatible default value applied at a low level.

If it is about these two functions, maybe a change of the position would reduce it again to "patch"? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would, yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freben I moved the new optional parameter to the end

plugins/catalog-backend-module-msgraph/README.md Show resolved Hide resolved
@freben
Copy link
Member

freben commented Mar 14, 2022

@pjungermann just a small ping here :)

@pjungermann
feat(msgraph): support advanced querying capabilities
759b32b 
Support advanced querying capabilities
using the new config option

```
queryMode?: 'basic' | 'advanced'
```

which will set all required headers and
query parameters.

Closes: backstage#9795
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
freben
freben approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight!

@freben freben merged commit 9486c3e into backstage:master Mar 14, 2022
@pjungermann pjungermann deleted the PJ_msgraph_advanced-queries branch March 14, 2022 14:31
@pjungermann pjungermann mentioned this pull request Mar 23, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehrnst ehrnst ehrnst left review comments

@freben freben freben approved these changes

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catalog-backend-module-msgraph: support advanced query capabilities
3 participants
@pjungermann @ehrnst @freben