Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version-bump workflow #65

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

awanlin
Copy link
Collaborator

@awanlin awanlin commented Sep 2, 2022

Signed-off-by: Andre Wanlin 67169551+awanlin@users.noreply.github.com

Hey, I just made a Pull Request!

Added a new action/workflow that automates the version bump process to keep the demo site up to date and can also be used as an example for the large Backstage Community.

When this action/workflow runs it will run the yarn backstage-cli versions:bump command which will upgrade all the packages as needed and then create a Pull Request with the changes. The PR description will include the new version and links to the release's Changelog and to the Upgrade Helper with current and new version set. There is also a link to the action/workflow that created the PR.

Finally a GitHub PAT will need to be provided as this will allow the new version-bump workflow/action to trigger the related CI build to validate the changes. This needs to be added as secret with the name VERSION_BUMP_TOKEN and will need "Full control of private repositories" access, but this might be adjusted as I haven't fully tested reduced access

Here's a screen shot of the Pull Request:

Screen Shot 2022-09-02 at 12 53 58 PM

Closes #63

@jhaals
Copy link
Member

jhaals commented Sep 21, 2022

Hey Andrew sorry sorry sorry for not picking this up earlier. I missed your message and I do not monitor this repository. I'll get my review glasses on. 👓

Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some initial thoughts! Feel free to poke me on Discord if I go silent again

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved
.github/workflows/version-bump.yml Outdated Show resolved Hide resolved
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
@awanlin
Copy link
Collaborator Author

awanlin commented Nov 12, 2022

@jhaals ready for another review :)

Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @awanlin 👏

.github/workflows/version-bump.yml Outdated Show resolved Hide resolved
.github/workflows/version-bump.yml Show resolved Hide resolved
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
@awanlin
Copy link
Collaborator Author

awanlin commented Nov 15, 2022

@jhaals ready to approve and merge now 🚀

Copy link
Member

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jhaals jhaals merged commit c2110a4 into backstage:master Nov 16, 2022
@awanlin awanlin deleted the topic/automate-version-bump branch November 16, 2022 13:44
@awanlin
Copy link
Collaborator Author

awanlin commented Nov 16, 2022

Awesome! Thanks @jhaals. Now we wait till next Wednesday for the PR 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping the Demo Up to Date
2 participants