Jasmine karma #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expresses server side serverside rendering npm start to build and start jsx parser setup
for server rendering - we can pick and choose at want point to start any ajax - did mount if for client only
TODO: * phantomjs needs a shim because it doesn't have prototype.bind natively * fix /server/**/*.js preprocessing
|
This is great. Ran a few tests using To get it running I had to manually install
|
|
Yeah, I will probably remove the karma-cli dependency and just make the 'npm test' command slightly longer. (Because karma-cli wants to be in the global install, not the dev-dependencies) |
|
@tommyh karma-cli seems fine being a dev dependency. You just have to run it from a package.json script, because that adds ./node_modules/.bin/ to your PATH. I'm on a Mac, does this not work on your OS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #2.
Does this make sense so far?