Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the rsync/ssh mover #370

Open
Tracked by #363
JohnStrunk opened this issue Aug 11, 2022 · 2 comments
Open
Tracked by #363

Deprecate the rsync/ssh mover #370

JohnStrunk opened this issue Aug 11, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@JohnStrunk
Copy link
Member

JohnStrunk commented Aug 11, 2022

Describe the feature you'd like to have.
The rsync/ssh mover's functionality will be replaced by an equivalent mover that uses rsync/stunnel to send the data over a TLS/PSK transport instead of ssh.

What is the value to the end user? (why is it a priority?)
The rsync/ssh mover requires additional capabilities that make it incompatible with the PSS/Restricted security level. In order to provide better cluster security, this mover should be deprecated in favor of an stunnel-based one.

How will we know we have a good solution? (acceptance criteria)

  • Provide a multi-stage deprecation over several releases:
    1. Post an event telling users to switch to the new mover
    2. Require the Namespace annotation Support a Namespace annotation indicating elevated privileges are ok for movers #365 in order to use this mover, and if missing, expose that in the RS/RD Syncing status condition
    3. Remove the rsync/ssh mover. There is no rush on actual removal as the Namespace annotation requirement will be sufficient to wall it off

Additional context

@project-bot project-bot bot added this to Incoming in VolSync work items Aug 11, 2022
@JohnStrunk JohnStrunk changed the title Deprecate the old rsync/ssh mover since we can't sufficiently reduce its permissions Deprecate the rsync/ssh mover Aug 11, 2022
@JohnStrunk JohnStrunk added this to the Version 0.7 milestone Dec 7, 2022
@JohnStrunk JohnStrunk added the enhancement New feature or request label Dec 7, 2022
@JohnStrunk
Copy link
Member Author

#516 adds a note to the rsync-ssh docs that users should move to rsync-tls

@JohnStrunk
Copy link
Member Author

Proposed schedule:

  • release-0.7 ➡ Post event to encourage migration
  • release-0.8 ➡ Require Namespace annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants