Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsync-tls: Add documentation for new rsync-tls mover #516

Merged
merged 2 commits into from
Dec 15, 2022
Merged

rsync-tls: Add documentation for new rsync-tls mover #516

merged 2 commits into from
Dec 15, 2022

Conversation

JohnStrunk
Copy link
Member

Describe what this PR does
Adds docs for the new mover

Is there anything that requires special attention?

Related issues:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JohnStrunk JohnStrunk force-pushed the rsync-tls-docs branch 3 times, most recently from a1ac439 to 0f5fd62 Compare December 6, 2022 15:15
@JohnStrunk JohnStrunk mentioned this pull request Dec 6, 2022
Merged
4 tasks
@JohnStrunk JohnStrunk linked an issue Dec 7, 2022 that may be closed by this pull request
Create a new rsync-based mover that uses stunnel w/ PSK instead of ssh #364
Closed
@JohnStrunk JohnStrunk mentioned this pull request Dec 8, 2022
Open
@JohnStrunk
rsync-tls: Add documentation
b03db87 
Signed-off-by: John Strunk <jstrunk@redhat.com>
@JohnStrunk
docs: Add info about privileged movers
1f01e9d 
Signed-off-by: John Strunk <jstrunk@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@JohnStrunk JohnStrunk marked this pull request as ready for review December 12, 2022 18:52
@JohnStrunk JohnStrunk mentioned this pull request Dec 14, 2022
Closed
@JohnStrunk
Copy link
Member Author

/cc @tesshuflower

tesshuflower
tesshuflower approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 39a85b7 into backube:main Dec 15, 2022
@JohnStrunk JohnStrunk deleted the rsync-tls-docs branch January 3, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesshuflower tesshuflower tesshuflower approved these changes

Assignees

@tesshuflower tesshuflower

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new rsync-based mover that uses stunnel w/ PSK instead of ssh
3 participants
@JohnStrunk @tesshuflower @openshift-merge-robot