-
Notifications
You must be signed in to change notification settings - Fork 676
/
errors_spec.rb
476 lines (418 loc) · 14 KB
/
errors_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
# encoding: utf-8
require File.expand_path('../spec_helper.rb', __FILE__)
module Backup
describe 'Backup Errors' do
shared_examples 'a nested exception' do
let(:class_name) { described_class.name.sub(/^Backup::/, '') }
context 'with stubbed constants' do
before do
ErrorA = Class.new(described_class)
ErrorB = Class.new(described_class)
ErrorC = Class.new(described_class)
end
after do
Backup.send(:remove_const, :ErrorA)
Backup.send(:remove_const, :ErrorB)
Backup.send(:remove_const, :ErrorC)
end
it 'allows errors to cascade through the system' do
expect do
begin
begin
begin
raise StandardError, 'error message'
rescue => err
raise ErrorA.wrap(err), <<-EOS
an error occurred in Zone A
the following error should give a reason
EOS
end
rescue Exception => err
raise ErrorB.wrap(err)
end
rescue Exception => err
raise ErrorC.wrap(err), 'an error occurred in Zone C'
end
end.to raise_error {|err|
expect( err.message ).to eq(
"ErrorC: an error occurred in Zone C\n" +
"--- Wrapped Exception ---\n" +
"ErrorB\n" +
"--- Wrapped Exception ---\n" +
"ErrorA: an error occurred in Zone A\n" +
" \n" +
" the following error should give a reason\n" +
"--- Wrapped Exception ---\n" +
"StandardError: error message"
)
}
end
end
context 'with no wrapped exception' do
describe '#initialize' do
it 'sets message to class name when not given' do
err = described_class.new
expect( err.message ).to eq class_name
end
it 'prefixes given message with class name' do
err = described_class.new('a message')
expect( err.message ).to eq class_name + ': a message'
end
it 'formats message' do
err = described_class.new(<<-EOS)
error message
this is a multi-line message
the above blank line will remain
the blank line below will not
EOS
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
" this is a multi-line message\n" +
" \n" +
" the above blank line will remain\n" +
" the blank line below will not"
)
end
# This usage wouldn't be expected if using this Error class,
# since you would typically use .wrap, but this is the default
# behavior for Ruby if you want to raise an exception that takes
# it's message from another exception.
#
# begin
# ...code...
# rescue => other_error
# raise MyError, other_error
# end
#
# Under 1.8.7/1.9.2, the message is the result of other_err.inspect,
# but under 1.9.3 you get other_err.message.
# This Error class uses other_error.message under all versions.
# Note that this will format the message.
it 'accepts message from another error' do
other_err = StandardError.new " error\nmessage "
err = described_class.new(other_err)
expect( err.message ).to eq class_name + ": error\n message"
end
end # describe '#initialize'
# i.e. use of raise with Error class
describe '.exception' do
it 'sets message to class name when not given' do
expect do
raise described_class
end.to raise_error {|err|
expect( err.message ).to eq class_name
}
end
it 'prefixes given message with class name' do
expect do
raise described_class, 'a message'
end.to raise_error {|err|
expect( err.message ).to eq class_name + ': a message'
}
end
it 'formats message' do
expect do
raise described_class, <<-EOS
error message
this is a multi-line message
the above blank line will remain
the blank line below will not
EOS
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
" this is a multi-line message\n" +
" \n" +
" the above blank line will remain\n" +
" the blank line below will not"
)
}
end
# see note under '#initialize'
it 'accepts message from another error' do
expect do
begin
raise StandardError, " wrapped error\nmessage "
rescue => err
raise described_class, err
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: wrapped error\n" +
" message"
)
}
end
it 'allows backtrace to be set (with message)' do
expect do
raise described_class, 'error message', ['bt']
end.to raise_error {|err|
expect( err.message ).to eq class_name + ': error message'
expect( err.backtrace ).to eq ['bt']
}
end
it 'allows backtrace to be set (without message)' do
expect do
raise described_class, nil, ['bt']
end.to raise_error {|err|
expect( err.message ).to eq class_name
expect( err.backtrace ).to eq ['bt']
}
end
end # describe '.exception'
# i.e. use of raise with an instance of Error
describe '#exception' do
it 'sets message to class name when not given' do
expect do
err = described_class.new
raise err
end.to raise_error {|err|
expect( err.message ).to eq class_name
}
end
it 'prefixes given message with class name' do
expect do
err = described_class.new 'a message'
raise err
end.to raise_error {|err|
expect( err.message ).to eq class_name + ': a message'
}
end
it 'formats message' do
expect do
err = described_class.new(<<-EOS)
error message
this is a multi-line message
the above blank line will remain
the blank line below will not
EOS
raise err
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
" this is a multi-line message\n" +
" \n" +
" the above blank line will remain\n" +
" the blank line below will not"
)
}
end
it 'allows message to be overridden' do
expect do
err = described_class.new 'error message'
raise err, 'new message'
end.to raise_error {|err|
expect( err.message ).to eq class_name + ': new message'
}
end
# see note under '#initialize'
it 'accepts message from another error' do
expect do
begin
raise StandardError, " wrapped error\nmessage "
rescue => err
err2 = described_class.new 'message to be replaced'
raise err2, err
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: wrapped error\n" +
" message"
)
}
end
it 'allows backtrace to be set (with new message)' do
initial_error = nil
expect do
err = described_class.new 'error message'
initial_error = err
raise err, 'new message', ['bt']
end.to raise_error {|err|
expect( err.message ).to eq class_name + ': new message'
expect( err.backtrace ).to eq ['bt']
# when a message is given, a new error is returned
expect( err ).not_to be initial_error
}
end
it 'allows backtrace to be set (without new message)' do
initial_error = nil
expect do
err = described_class.new 'error message'
initial_error = err
raise err, nil, ['bt']
end.to raise_error {|err|
expect( err.backtrace ).to eq ['bt']
expect( err.message ).to eq class_name + ': error message'
# when no message is given, returns self
expect( err ).to be initial_error
}
end
it 'retains backtrace (with message given)' do
initial_error = nil
expect do
begin
raise described_class, 'foo', ['bt']
rescue Exception => err
initial_error = err
raise err, 'bar'
end
end.to raise_error {|err|
expect( err.backtrace ).to eq ['bt']
expect( err.message ).to eq class_name + ': bar'
# when a message is given, a new error is returned
expect( err ).not_to be initial_error
}
end
it 'retains backtrace (without message given)' do
initial_error = nil
expect do
begin
raise described_class, 'foo', ['bt']
rescue Exception => err
initial_error = err
raise err
end
end.to raise_error {|err|
expect( err.backtrace ).to eq ['bt']
# when no message is given, returns self
expect( err ).to be initial_error
}
end
end # describe '#exception'
end # context 'with no wrapped exception'
context 'with a wrapped exception' do
describe '.wrap' do
it 'wraps #initialize to reverse parameters' do
ex = mock
described_class.expects(:new).with(nil, ex)
described_class.expects(:new).with('error message', ex)
described_class.wrap(ex)
described_class.wrap(ex, 'error message')
end
it 'appends wrapped error message' do
orig_err = StandardError.new 'wrapped error message'
err = described_class.wrap(orig_err, 'error message')
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error message"
)
end
it 'leaves wrapped error message formatting as-is' do
orig_err = StandardError.new " wrapped error\nmessage "
err = described_class.wrap(orig_err, <<-EOS)
error message
this error is wrapping another error
EOS
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
" \n" +
" this error is wrapping another error\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error\n" +
"message "
)
end
end # describe '.wrap'
# i.e. use of raise with an instance of Error
describe '#exception' do
it 'appends wrapped error message' do
expect do
begin
raise StandardError, " wrapped error\nmessage "
rescue => err
raise described_class.wrap(err), <<-EOS
error message
this error is wrapping another error
EOS
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
" \n" +
" this error is wrapping another error\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error\n" +
"message "
)
}
end
# see note under '#initialize'
it 'accepts message from another error' do
expect do
begin
raise StandardError, " wrapped error\nmessage "
rescue => err
raise described_class.wrap(err), err
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: wrapped error\n" +
" message\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error\n" +
"message "
)
}
end
it 'uses backtrace from wrapped exception' do
expect do
begin
raise StandardError, 'wrapped error message', ['bt']
rescue => err
raise described_class.wrap(err), 'error message'
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error message"
)
expect( err.backtrace ).to eq ['bt']
}
end
it 'allows wrapped error backtrace to be overridden' do
expect do
begin
raise StandardError, 'wrapped error message', ['bt']
rescue => err
raise described_class.wrap(err), 'error message', ['new bt']
end
end.to raise_error {|err|
expect( err.message ).to eq(
"#{ class_name }: error message\n" +
"--- Wrapped Exception ---\n" +
"StandardError: wrapped error message"
)
expect( err.backtrace ).to eq ['new bt']
}
end
# Since a new message is given, a new error will be created
# which would take the bt from the wrapped exception (nil).
# So, the existing bt is set on the new error in this case.
# With no message given (a simple re-raise), #exception would simply
# return self, in which case the bt set by raise would remain.
# It would be rare for a wrapped exception not to have a bt.
it 'retains backtrace if wrapped error has none' do
expect do
begin
err = StandardError.new 'foo'
raise described_class.wrap(err), nil, ['bt']
rescue Exception => err2
raise err2, 'bar'
end
end.to raise_error {|err|
expect( err.backtrace ).to eq ['bt']
}
end
end # describe '#exception'
end # context 'with a wrapped exception'
end # shared_examples 'a nested exception'
describe Error do
it_behaves_like 'a nested exception'
end
describe FatalError do
it_behaves_like 'a nested exception'
end
end # describe 'Backup Errors'
end