Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Firebird backup using gbak #578

Closed
wants to merge 1 commit into from
Closed

Adding Firebird backup using gbak #578

wants to merge 1 commit into from

Conversation

marlonandrade
Copy link

No description provided.

@tombruijn
Copy link
Member

Hi @marlonandrade, thanks for the PR. Could you explain briefly what Firebird is and why it would be a good addition as a storage option? Because based on what I read I'm a bit confused about it being a SQL database system. Would that mean you also store files (so non database data) in that DB?

@marlonandrade
Copy link
Author

Hi @tombruijn, sorry for not explaining it better on the PR.

It is an old SQL database system (http://www.firebirdsql.org/).
It's an open source database that was largely used here in Brazil in the early 2000 on Delphi and Visual Basic softwares because of its portability and was very easy to install as a dependency of the software. I would say that no sane person starts a project using it anymore, but sometimes we have to maintain some legacy

In our internal software stack we still have a system using it and we wanted to keep the entire stack backed up using the gem, so that was the reason for the PR.

Thank you.

@tombruijn
Copy link
Member

I'm doubting to actually pull it in if it's a system no sane person would use today. I understand the personal need for it, but how many people will actually use it now or in the future. I'll think about it..

@tombruijn
Copy link
Member

After some thought I decided not to merge this in. If it's an old system and not a lot of users I feel that it doesn't belong in the core. With v5's architecture it might be easier to add it as a external module without it being part of the main repository.

Thanks for the work @marlonandrade. I hope you understand my decision. I hope you can use a fork, by referencing it in the backup's project gemfile.

@tombruijn tombruijn closed this Sep 12, 2014
@marlonandrade
Copy link
Author

Hi @tombruijn I do understand and also agree. I'm already using my fork.
I was going to suggest some pluggable way to add it, but as you said it is already planned for v5 =)

Thank you for your feedback and good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants