configure.pl: Introduce --config-only option (#15) #62
Conversation
This adds ability to skip installation phase and intended for using mostly
by packagers. It is assumed that the OS distribution package should install
configure.pl somewhere and provide a wrapper script for users like:
```sh
PERL5LIB=/usr/local/lib
perl %%PREFIX%%/libexec/backuppc/configure.pl \
--config-only
--bin-path perl=%%PREFIX%%/bin/perl \
--config-dir %%ETCDIR%% \
--cgi-dir %%CGIDIR%% \
--data-dir /var/db/BackupPC \
--fhs \
--html-dir %%WWWDIR%% \
--html-dir-url /backuppc \
--install-dir %%PREFIX%% \
--log-dir /var/log/BackupPC
```
|
|
||
| printf("Installing config.pl and hosts in $DestDir$Conf{ConfDir}\n"); | ||
| InstallFile("conf/hosts", "$DestDir$Conf{ConfDir}/hosts", 0644) | ||
| InstallFile("conf/hosts", "$DestDir$Conf{ConfDir}/hosts.sample", 0644) |
There was a problem hiding this comment.
I don't understand the creation of hosts.sample, which happens when !$opts{"config-only"}. Why?
Similarly for config.pl.sample. If !$opts{"config-only"}, it seems they get created, but not used. If $opts{"config-only"}, they don't get created, but they do get used.
There was a problem hiding this comment.
This is all about making configure.pl more package friendly.
-
In general the
configure.plscript is executed at package creation time and installs the program into a staging directory. -
The preinstalled program files distributed as a package. A package installation is a basically copying that files into proper places on the hosts file sysytem.
-
After the package is installed user needs to run
configure.plagain to upgradeconfig.plfrom previous version (and maybe to configure new installation).
This time we should use--config-onlyoption to skip installation phase.
Since configure.pl uses conf/config.pl and BackupPC source code or distribution is not available, we should add conf/config.pl to the package and install it somewhere.
It is a common good practice to provide sample configuration files that could be used by user as a reference or to fall back to default configuration.
Basically they are copies of configuration files installed by a package.
My idea is we can have config.pl.sample for both [3] and as a sample. That is why it gets created if !$opts{"config-only"} and used if !$opts{"config-only"}.
hosts.sample doesn't needed for configure.pl, it is just a sample file. So, it should be created only once at installation time.
I know it is not an elegant solution, but it doesn't involves major rewriting of the configure.pl and will substantially simplify creation of BackupPC packages. That is very complicated for now since configure.pl makes modifications at once in program and configuration files.
|
Ok thanks for the explanation. I merged this. Thanks. |
This adds ability to skip installation phase and intended for using mostly
by packagers. It is assumed that the OS distribution package should install
configure.pl somewhere and provide a wrapper script for users like:
#!/bin/sh PERL5LIB=/usr/local/lib perl %%PREFIX%%/libexec/backuppc/configure.pl \ --config-only --bin-path perl=%%PREFIX%%/bin/perl \ --config-dir %%ETCDIR%% \ --cgi-dir %%CGIDIR%% \ --data-dir /var/db/BackupPC \ --fhs \ --html-dir %%WWWDIR%% \ --html-dir-url /backuppc \ --install-dir %%PREFIX%% \ --log-dir /var/log/BackupPC