Implement missing data types for calendar and schedule #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies in bacapp switches
MightyPork
force-pushed
the
feat/calendars
branch
from
a74f17d
to
566a7e0
Compare
MightyPork
changed the title
|
I think this is ready now, but I haven't used the code in our app yet. Will update if I find any problems with it |
|
Waiting for #440 to merge, then this can be rebased & updated to new naming |
Closed
skarg
approved these changes
Feb 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the following:
SpecialEventstruct for theException_Scheduleproperty ofScheduleCalendarEntrystruct for theDate_Listproperty ofCalendar, and as part of theSpecialEventstruct (I based it on Feature/oscbs 29 calendar time object #440, there will be a merge conflict. I made some changes and the function naming in the PR is probably wrong)DateRangestruct for theEffective_Periodproperty ofScheduleCurrently all structs are implemented, nothing is tested yet.
I won't implement the printing and parsing functions for now, It's a lot of work and I don't need these.