Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with simultaneous events #22

Open
raimohanska opened this issue Nov 4, 2013 · 1 comment
Open

Doesn't work with simultaneous events #22

raimohanska opened this issue Nov 4, 2013 · 1 comment

Comments

@raimohanska
Copy link
Contributor

Failing case:

    a = Bacon.Model()
    f = a.lens("first").log("first")
    l = a.lens("last").log("last")
    stuff = Bacon.Model.combine({f, l}).log("stuff")
    values = collect(stuff)
    a.set({first:"f", last:"l"})
    expect(values).to.deep.equal([{}, {first: "f", last: "l"}])

I stumbled upon this when testing Bacon.js 0.7.0 in a project.

raimohanska pushed a commit that referenced this issue Nov 4, 2013
@raimohanska
Copy link
Contributor Author

Fixed in 0.3.13.

Problem was the "pingpong-prevention" logic that was based on modCount. Now it's based on a "modStack". Should be reliable. Has some performance penalty, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant