Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-delegating form of event binding #140

Closed
wants to merge 1 commit into from

Conversation

joefiorini
Copy link
Member

I need to bind directly to an element using http://craig.is/riding/gators. In addition to the typical delegation, it also supports the direct binding form:

Gator(document).bind("click", function(e){
  //...
});

This did not work as we are still passing the selector as undefined when it isn't passed.

@raimohanska
Copy link
Contributor

Ok! Automatic tests, readme example for gatorjs todo and we'll be good to merge.

@joefiorini
Copy link
Member Author

I can write a test for this. What do you mean by "readme example for gatorjs todo"? Do you want me to create a todo comment or a readme example based on todomvc?

@raimohanska
Copy link
Contributor

Haha! My bad, i just meant that tests and an example to readme should be added. No todomvc here ;)

@raimohanska
Copy link
Contributor

Are you still working on this?

@joefiorini
Copy link
Member Author

Yes, I have a few other projects going on, but I'll be getting to it
soon. Thanks for checking back!

Juha Paananen mailto:notifications@github.com
April 9, 2013 6:59 AM

Are you still working on this?


Reply to this email directly or view it on GitHub
#140 (comment).

@raimohanska
Copy link
Contributor

Joe, I'm closing this for now. Re-open anytime if this still is in your interests!

@wolfflow
Copy link
Member

Check 'tis out, it works for me = )

Gator::asEventStream = (eventName, selector, eventTransformer) ->
  selector = selector ? "_root"
  Bacon.$.asEventStream.call(@, eventName, selector, eventTransformer)

@wolfflow wolfflow reopened this Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants