-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rwlock (and bswap8 because oops) #38
Conversation
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 96.25% 96.26% +0.01%
==========================================
Files 52 52
Lines 3735 3745 +10
Branches 276 276
==========================================
+ Hits 3595 3605 +10
Misses 128 128
Partials 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking pretty good - the only changes we've noted (and we've only noted the first instance of each to keep the review light) are really stylistic consistency with the rest of the code base, and a note about how SUBSTRATE_NO_DISCARD() was intended to be used
We don't mind if you want to fix the points before merge or have us fix them after in a clean-up pass - just let us know which you'd like to do and we'll adjust the approval accordingly. Exciting to soon have a proper rwlock type available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing those items - we'll merge this just as soon as the builds complete
This is just an initial draft of
rwlock
for #18, as it usesstd::shared_mutex
it's exclusive to C++17 or newer.