Fix: command_line review items & Coverity lints #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 92.62% 92.01% -0.61%
==========================================
Files 47 47
Lines 3175 3208 +33
Branches 609 626 +17
==========================================
+ Hits 2941 2952 +11
- Misses 177 188 +11
- Partials 57 68 +11
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amyspark
requested changes
Jun 6, 2023
|
@dragonmux One more comment which I forgot to add: is there a way to force a test for those |
|
Pushed fixes for the various review items - thank you Amy! We've been contemplating the valueless_by_exception() problem and haven't yet thought of something - unfortunately. |
dragonmux
force-pushed
the
fix/command-line-review-items
branch
2 times, most recently
from
1877b9f
to
6b5290f
Compare
amyspark
approved these changes
Jun 13, 2023
|
We'll rebase this and get this merged then, thank you 🙂 |
…lueless_by_exception() making its way into expressions it shouldn't
…a check for std::variant::valueless_by_exception()
… check for std::variant::valueless_by_exception()
…ions Catch2 can throw
…ving capacity in the result vectors
dragonmux
force-pushed
the
fix/command-line-review-items
branch
from
6b5290f
to
ae3b4e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the review items bought up when code reviewing <substrate/command_line> with @freyjadomville. It also addresses several items found when running a Coverity scan such as missed handling of
std::variant::valueless_by_exception() == true, resulting in possible exception throwing.Additionally, by request, this addresses some exception mishaps in affinity_t's tests too (again, found by Coverity). As we addressed those, we also cast the net a little broader and went after lints in other parts of the library to help reduce the Coverity footprint and improve the code quality.