Assorted codegen fixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 92.01% 92.01% -0.01%
==========================================
Files 47 47
Lines 3208 3207 -1
Branches 626 626
==========================================
- Hits 2952 2951 -1
+ Misses 188 185 -3
- Partials 68 71 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dragonmux
requested changes
Jun 7, 2023
dragonmux
approved these changes
Jun 13, 2023
dragonmux
merged commit 89725c6
into
bad-alloc-heavy-industries:main
85 of 86 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dragonmux,
This PR is to propose some slight changes to the substrate build defaults, for better codegen out of the box. I also added some fixes that slipped CI since the libraries are usually built as shared.
Let me know what you think.