Feature: command line parser enabled var #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build to signal if the command line parser part has been enabled
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 90.38% 90.38%
=======================================
Files 47 47
Lines 3277 3277
Branches 644 644
=======================================
Hits 2962 2962
Misses 250 250
Partials 65 65 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amyspark
approved these changes
Aug 31, 2023
impl/meson.build
Outdated
| @@ -205,6 +210,17 @@ endif | |||
| if meson.is_cross_build() | |||
| hostCXX = meson.get_compiler('cpp', native: true) | |||
There was a problem hiding this comment.
Might want to rename this for consistency (buildCXX).
…s don't get screwy when, eg, cross-compiling from Linux to Windows
…d) to `buildCXX`for consistency with Meson's own nomenclature
dragonmux
force-pushed
the
feature/command-line-parser-enabled-var
branch
from
0708039
to
4ff801c
Compare
|
Both items should now be addressed - with thanks for spotting and raising them |
amyspark
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variable to the build system to denote when the command line parser has been enabled. This is to allow dependent builds to detect this condition and depend on the command line parser.
Additionally, this PR sorts a long-standing issue with the host vs target (native, non-native) builds where state from one would leak into the other in potentially bad ways and cause a malodorous mess if cross-compiling to Windows from Linux (for example).