-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Improved Windows console text handling #79
Feature: Improved Windows console text handling #79
Conversation
…d and getting those out to the console
0ecc4ca
to
12f57b0
Compare
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 90.38% 89.77% -0.62%
==========================================
Files 47 47
Lines 3277 3414 +137
Branches 644 660 +16
==========================================
+ Hits 2962 3065 +103
- Misses 247 313 +66
+ Partials 68 36 -32
... and 8 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the test suite needing some love, there is one issue that requires sorting out.
acefa09
to
cc303f4
Compare
…rying to configure certain kinds of cross-compilation build
515449c
to
fb4dbe0
Compare
This PR aims to improve how we handle strings in console_t/consoleStream_t on Windows and in general Unicode handling on output.
This fixes an issue where std::string's containing UTF-8 would not get converted on Windows, resulting in garbled output.
We also implement support for std::wstring/wchar_t and std::u16String/char16_t strings though the former is only for Windows. This should allow any UTF-16 or wide Windows character strings to be correctly displayed in a program's output just the same as any other strings.
Some of the architectural changes should also provide a nice speed boost for STL string containers by not throwing away the length information only to have to re-calculate it.