Feature: Improved command-line arguments parsing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… making options global and exclusive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 89.18% 89.24% +0.06%
==========================================
Files 47 47
Lines 3459 3516 +57
Branches 669 688 +19
==========================================
+ Hits 3085 3138 +53
- Misses 338 339 +1
- Partials 36 39 +3 ☔ View full report in Codecov by Sentry. |
amyspark
requested changes
Jan 10, 2024
amyspark
reviewed
Jan 10, 2024
…eArgument() to be able to take a set of options to recognise through the recursion step
…of global options through recursive arguments_t::parseFrom() calls
…bypass the required arguments checking if exactly one is given
A broken `= default;` in the header is recoverable by forward declaring in the header, then using it in a translation unit (once the class is complete).
dragonmux
force-pushed
the
feature/improved-args-parsing
branch
from
b7c8c48
to
dee2062
Compare
amyspark
reviewed
Jan 10, 2024
…r `noexcept` markings noting that std::multiset can throw when copied
dragonmux
force-pushed
the
feature/improved-args-parsing
branch
from
dee2062
to
b74a01b
Compare
amyspark
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we seek to improve the state of the command line arguments parser by implementing two new features that solve usability problems and bring us closer to parity with Rust's Clap and Python's argparse.
The first of these new features is option exclusivity, whereby you can define multiple options at a parsing level to be exclusive of one another and bypass requirements checks for normal options - this is done with the new options_t helper
.exclusive()and allows, eg,--versionand--helpto be defined and made exclusive of each other + uncaring of other arguments requirements validity.The second of these features is option globalness, whereby an option can be defined to be "global" (visible to its level and all parsing levels below that) such as a
--helpoption that should appear on every level of parsing (through optionSet_t barriers) to improve the usage of the parser.