Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML input is not sanitized #36

Closed
gianklug opened this issue Nov 19, 2021 · 7 comments · May be fixed by #41
Closed

HTML input is not sanitized #36

gianklug opened this issue Nov 19, 2021 · 7 comments · May be fixed by #41
Labels
next release fixed in develop branch and will be part of the next release

Comments

@gianklug
Copy link

You can use any HTML as and can even inject javascript by using <img src="broken" onerror="your_js_code"></img>. If many users are using snapweb, this could be considered a security issue.

@badaix
Copy link
Owner

badaix commented Nov 19, 2021

Where and how you can use any HTML?

@gianklug
Copy link
Author

In the Device nickname field

@badaix
Copy link
Owner

badaix commented Nov 19, 2021

True, seems that the readme is still valid :)

This web client is the author's first JavaScript/TypeScript project and is rather a proof of concept for the Snapserver's WebSocket API.

@nanderer
Copy link

nanderer commented Jan 9, 2022

is this issue mentioned only reflecting to client side java script or even to server side?

@gianklug
Copy link
Author

gianklug commented Jan 10, 2022 via email

@badaix
Copy link
Owner

badaix commented Jan 10, 2022

The server doesn't interpret any JavaScript, it just serves files within the doc root directory

@badaix badaix added the next release fixed in develop branch and will be part of the next release label Mar 4, 2024
@badaix
Copy link
Owner

badaix commented Mar 7, 2024

Fixed in v0.6.0

@badaix badaix closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants