Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory tooltips do not respect "Show Mod Names" #12

Closed
0x5c opened this issue Mar 3, 2021 · 2 comments
Closed

Inventory tooltips do not respect "Show Mod Names" #12

0x5c opened this issue Mar 3, 2021 · 2 comments
Labels
bug Something isn't working fabric

Comments

@0x5c
Copy link

0x5c commented Mar 3, 2021

Issue Description:

WTHIT adds the mod name to inventory tooltips even with the "Show Mod Names" set to off.

WTHIT is confirmed to be the cause since the format string set in WTHIT appears in the tooltip (adding random letters shows in the tooltip

What you expected to happen:

I expect WTHIT to not even touch normal item tooltips without there being a config item for it.

Steps to reproduce:

  1. Turn "Show Mod Names" to off
  2. Set a custom format string for mod names, preferably by adding random letters (not needed for bug but needed for demo)
  3. Observe the format string being present in all item tooltips

Affected Versions (Do not use "latest"):

  • WTHIT: v2.3.0+1.16.5
  • Minecraft: 1.16.5
  • Fabric API: v0.30.3+1.16

Possible Conflicting Mods (Provide their version, as well)

I don't see what other mod could be having this behaviour.

Screenshots

image
image
image

@deirn
Copy link
Member

deirn commented Mar 4, 2021

Honestly yeah, I agree that it shouldn't even have that feature. I'll remove it altogether since I believe REI has mod name tooltip too? When you use waila you probably also use rei anyway.

@0x5c
Copy link
Author

0x5c commented Mar 4, 2021

That's pretty much what I was thinking, it's already a feature of REI.

deirn added a commit that referenced this issue Mar 4, 2021
@deirn deirn closed this as completed Mar 4, 2021
@deirn deirn added bug Something isn't working fabric labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric
Development

No branches or pull requests

2 participants