Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ProAWS Commerce CRUD #176

Merged
merged 8 commits into from
May 10, 2024
Merged

feat: ProAWS Commerce CRUD #176

merged 8 commits into from
May 10, 2024

Conversation

joelhooks
Copy link
Collaborator

commerce

@joelhooks
feat: basic commerce crud
af3d6ad 
this commit is a good example of the overlap in commerce between the two, specifically with routing
@joelhooks
feat: email login works
c996c28
@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
course-builder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:37pm
course-builder-poc ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:37pm
pro-aws ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:37pm

@socket-security Socket Security
Copy link

socket-security bot commented May 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@typescript-eslint/eslint-plugin@6.21.0 None +3 3.75 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 None +1 629 kB jameshenry

View full report↗︎

joelhooks
joelhooks commented May 10, 2024
View reviewed changes
Copy link
Collaborator Author

@joelhooks joelhooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a ton of duplication, but this is in a good spot for now to build on and ship the first workshop

apps/course-builder-web/src/inngest/inngest.config.ts
Comment on lines -30 to -34
inngest.createFunction(
stripeCheckoutSessionCompletedConfig,
stripeCheckoutSessionCompletedTrigger,
stripeCheckoutSessionCompletedHandler,
),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combined all of these into the core functions that are being mapped above

apps/pro-aws/src/app/(commerce)/invoices/[merchantChargeId]/page.tsx Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the most part these pages are all just cut and pasted directly from Course Builder Web (ported from Skill Stack)

@joelhooks joelhooks requested a review from vojtaholik May 10, 2024 17:50
@joelhooks joelhooks merged commit a939e2b into main May 10, 2024
15 checks passed
@joelhooks joelhooks deleted the joel/proaws-add-commerce branch May 10, 2024 21:50
@joelhooks joelhooks mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtaholik vojtaholik Awaiting requested review from vojtaholik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joelhooks