fix(nonGlobalStepDefinitions): .features files now work with webpack

badeball · Jul 2, 2020 · 65ee0a4 · 65ee0a4
1 parent 7d4a3d5
commit 65ee0a4
Show file tree

Hide file tree

Showing 2 changed files with 100 additions and 37 deletions.
diff --git a/lib/featuresLoader.js b/lib/featuresLoader.js
@@ -24,18 +24,24 @@ const createCucumber = (
 
   var moduleCache = arguments[5];
 
+  function isWebpack(){
+    return !!require.cache;
+  }
+
   // Stolen from https://github.com/browserify/browserify/issues/1444
-  function clearFromCache(instance)
+  function clearFromCacheBrowserify(instance)
   {
-      for(var key in moduleCache)
+      if(isWebpack()) return;
+      
+      for(const key in moduleCache)
       {
           if(moduleCache[key].exports == instance)
           {
               delete moduleCache[key];
               return;
           }
       }
-      throw "could not clear instance from module cache";
+      throw new Error("could not clear instance from browserify module cache");
   }
 
   ${globalToRequire.join("\n")}
@@ -70,7 +76,7 @@ module.exports = function(_, filePath = this.resourcePath) {
   if (isNonGlobalStepDefinitionsMode()) {
     nonGlobalStepDefinitionsToRequire = features.map(featurePath => ({
       [featurePath]: getStepDefinitionsPaths(featurePath).map(
-        sdPath => `clearFromCache(require('${sdPath}'))`
+        sdPath => `clearFromCacheBrowserify(require('${sdPath}'))`
       )
     }));
   } else {