Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: remove reversal of After hooks order #1193

Closed
drcthrive opened this issue Jun 3, 2024 · 2 comments
Closed

Enhancement request: remove reversal of After hooks order #1193

drcthrive opened this issue Jun 3, 2024 · 2 comments

Comments

@drcthrive
Copy link

The reversal of the After hooks order in this pr - #1128 - really is not logical, you put in an order 1,2,3 and it processes it runtime as 3,2,1; if you set an order you expect it to process in the order you state, not have to work out things backwards

Would you be open to a PR that removes this?

Also there is no mention of order in the documentation, will add that if this gets a greenlight

@badeball
Copy link
Owner

badeball commented Jun 3, 2024

This was not introduced in the mentioned PR, but is mentioned in the changelog. It is sufficiently logical.

Edit: it is briefly mentioned under hooks ordering.

@badeball badeball closed this as completed Jun 3, 2024
@drcthrive
Copy link
Author

Oh my bad sorry thought it was in that pr. Thanks for pointing out the docs missed that too, was at silly oclock in the day and the brain was swimming. I will have to try and wrap my brain around 1,2,3 equals 3,2,1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants