Adding ordering in Before hook

[VidhiRambhia]

No description provided.

[badeball]

Default order should be made to 10000 in order to mimic behavior seen in other implementations, ref. cucumber/cucumber-jvm@1a5e98d.

[VidhiRambhia]

Done

[badeball]

Make this required and give it a default value during assignment.

[VidhiRambhia]

Makes sense, addressed this

[badeball]

Order is an option in all hooks in the jvm implementations and should such be added here given the goal is conformity.

[badeball]

Each hook deserve more comphrehensive testing than this and requires separate tests (ie. don't mix it with "the big one"). I imagine essentially three scenarios for each hook:

• Before / Before: in order
• Before / Before(order: 10000): in order
• Before / Before(order: 9999): reversed

.. with similar tests for each other type of hook. This can be accomplished using X scenario outlines.

[VidhiRambhia]

Order is an option in all hooks in the jvm implementations and should such be added here given the goal is conformity.

Thanks for your feedback, @badeball! So ordering has to be implemented in all of these - Before, After, BeforeStep, AfterStep, BeforeAll, AfterAll?

Also, I understand we reverse the order of After hooks
public resolveAfterHooks(tags: string[]) { return this.resolveCaseHooks("After", tags).reverse(); }
With the new approach which takes into account ordering, should this stay the same? ie we reverse sorted hooks?

[badeball]

Yes, all hooks and yes, reverse sorted in all after-type hooks!

[VidhiRambhia]

Each hook deserve more comphrehensive testing than this and requires separate tests (ie. don't mix it with "the big one"). I imagine essentially three scenarios for each hook:

• Before / Before: in order
• Before / Before(order: 10000): in order
• Before / Before(order: 9999): reversed

.. with similar tests for each other type of hook. This can be accomplished using X scenario outlines.

Is it a good idea to put all of these tests in the same feature file (hooks_ordering.feature)? Or should I create a separate feature file for each hook?

[badeball]

Is it a good idea to put all of these tests in the same feature file (hooks_ordering.feature)?

Yeah, one feature file is fine for this purpose.

[VidhiRambhia]

Addressed your comments @badeball. Please let me know your thoughts on it!

[badeball]

Excellent, thank you. I've merged and released this with v19.2.0. For reference, you can check out 1e3643a to see how I used scenario outlines to shorten everything.

[VidhiRambhia]

Excellent, thank you. I've merged and released this with v19.2.0. For reference, you can check out 1e3643a to see how I used scenario outlines to shorten everything.

I'll go through it. Thank you, @badeball!