Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding retries to config disables screenshots being added to html report #931

Closed
MassimoLobrutto opened this issue Jan 23, 2023 · 1 comment

Comments

@MassimoLobrutto
Copy link

When a test is run in normal mode screenshot has (failed).png suffix attached and is picked up correctly bu the html report

Add

retries: {
runMode: 1
},

to cypress config and rerun test

Expected - Screenshot to be picked up by html report
Actual - Screenshot is not picked up by report. This is probably due to any screen shot that is retried has the suffix (failed) (attempt 2).png attached and thus due to the addition of (attempt x) is not being picked up by the report

This repo will reproduce the issue

https://github.com/MassimoLobrutto/ErrorReproduction

After reproducing the issue, remove the retries entry from cypress config and the screenshot will return

badeball added a commit that referenced this issue Jan 29, 2023
badeball added a commit that referenced this issue Jan 29, 2023
badeball added a commit that referenced this issue Feb 1, 2023
This allows @cucumber/query (built into @cucumber/html-formatter) to
maintain state [1] and fixes #931 [2].

[1] https://github.com/cucumber/query/blob/v12.0.1/javascript/src/Query.ts#L46-L59
[2] #931
@badeball
Copy link
Owner

badeball commented Feb 1, 2023

Hey @MassimoLobrutto, thanks for reporting this issue. I've fixed it in v15.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants