fix(createtestfromscenario): switch from using Cypress fail event to … #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mocha runner fail event it seems that cypress fail event could have only one listener and in case user has own or other plugins use it cucumber json will be missing results for failed tests as this event is not emitted re #459, re#454, re#417, re#348
|
nice! I'm not exactly sure this will work but I will take a leap of faith here :) |
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@lgandecki aaaaah, that was too quick :) |
|
I see, damn, I assumed you tested it. :) I merged the other one as well, hopefully no one will use this release meanwhile |
|
I updates my test repository. #417 is not fixed by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mocha runner fail event
it seems that cypress fail event could have only one listener (Shelex/cypress-allure-plugin#57 (comment)) and in case user has own or other
plugins use it cucumber json will be missing results for failed tests as this event is not emitted
re #459, #454, #417, #348