Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"placeholder" property misspelled "placeHolder" in hal.ts #459

Closed
dayre opened this issue Jan 5, 2023 · 2 comments
Closed

"placeholder" property misspelled "placeHolder" in hal.ts #459

dayre opened this issue Jan 5, 2023 · 2 comments

Comments

@dayre
Copy link
Collaborator

dayre commented Jan 5, 2023

I'm using Spring HATEAOS which i can see is setting the placeholder property correctly but it isn't coming through in Ketting.

According to the HAL spec, it seems to be refered to as "placeholder", but in the hal.ts, it is looking at the halField "placeHolder" property with a capital "H".

From Spring:

"method": "POST",
            "properties": [
                {
                    "name": "cascade",
                    "prompt": "Apply to child systems ",
                    "placeholder": "When set, will copy report into subsystems / components. "
                },

placeholder: halField.placeHolder,

I believe this is a typo in hal.ts ? If so, i can submit a PR for it... just wanted to confirm.

@evert
Copy link
Collaborator

evert commented Jan 6, 2023

Yes, seems like this is a typo! PR is appreciated!

@dayre dayre linked a pull request Jan 6, 2023 that will close this issue
@dayre
Copy link
Collaborator Author

dayre commented Jan 6, 2023

I added another PR for hal-types which this change needs.

badgateway/hal-types#105

Not sure how best to deal with these cross repo dependency updates other than the separate PR's for each. Couldn't verify the changes to the tests without the hal-types PR in place. If there is an alternate way you prefer to handle these in the future, please let me know.

@evert evert closed this as completed in a97c155 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants