Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm distribution #36

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Update npm distribution #36

merged 5 commits into from
Jan 25, 2021

Conversation

vladimyr
Copy link
Contributor

This is really a bunch of chores to improve the development experience and distribution packaging.

@vercel
Copy link

vercel bot commented Jan 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/badgen/badgen-icons/8ndrhdn2f
✅ Preview: https://badgen-icons-git-fork-vladimyr-package.badgen.vercel.app

Copy link
Member

@amio amio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

Just one thing, the preview page is broken. IIRC index.js is for the preview page.

@vladimyr
Copy link
Contributor Author

Just one thing, the preview page is broken. IIRC index.js is for the preview page.

Sorry, I missed that one 🤦
It works now 🎉

return exportFromString(await res.text())
})
}
const fetchJSON = (url, init) => fetch(url, init).then(resp => resp.json());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amio amio merged commit c553e12 into badgen:master Jan 25, 2021
@vladimyr vladimyr deleted the package branch January 25, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants