Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Badge- getting error with require #66

Closed
bretonics opened this issue Jun 1, 2015 · 2 comments · Fixed by #69
Closed

New Badge- getting error with require #66

bretonics opened this issue Jun 1, 2015 · 2 comments · Fixed by #69

Comments

@bretonics
Copy link
Contributor

I'm trying to include a new size badge I really like, but after building and installing the gem locally I get this error:

require: cannot load such file -- badger/size (LoadError)

I added a size.rb file in /lib/badger/size.rb, which just adds the owner and repo to the badge string, and added require 'badger/size' to the /lib/badger.rb file.

My ruby is basic, but I can see that the build is not including my new size.rb file. I ran this to check:

gem contents --no-prefix badgerbadgerbadger | grep lib
lib/badger.rb
lib/badger/badge.rb
lib/badger/badger.rb
lib/badger/bonus.rb
lib/badger/cli.rb
lib/badger/config.rb
lib/badger/helpers.rb
lib/badger/license.rb
lib/badger/rubygem.rb
lib/badger/service.rb
lib/badger/version.rb

I think it will be a pretty cool extra badge to add to your code. Thanks!

@pikesley
Copy link
Member

pikesley commented Jun 1, 2015

Do you have a pull-request for what you did please?

@bretonics
Copy link
Contributor Author

Hi, sorry for the delay.

I was just about to commit and for some reason now the size file is included, but it doesn't work, so I'm making the pull request and you can give me your advice/opinion. I am sure I forgot to add something somewhere to print it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants