Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Specify the branch for service images. #24

Closed
jmalloc opened this issue Jan 10, 2014 · 7 comments
Closed

Specify the branch for service images. #24

jmalloc opened this issue Jan 10, 2014 · 7 comments

Comments

@jmalloc
Copy link
Contributor

jmalloc commented Jan 10, 2014

It would be awesome if the branch name could be specified for Coveralls and Travis images - assuming this isn't already possible? :)

@mathiasbynens
Copy link
Contributor

More info: for Travis, the URL format looks like:

https://travis-ci.org/mathiasbynens/jsesc.png?branch=master

gh-badges doesn’t support this yet AFAICT but it’s definitely possible to add support for this. Wanna submit a patch? :)

@espadrine
Copy link
Member

The current Travis URL is: http://b.adge.me/travis/<USER/REPO>.svg.

@jmalloc Tell me what you'd find nice. http://b.adge.me/travis/<USER/REPO/BRANCH>.svg, maybe?

@jmalloc
Copy link
Contributor Author

jmalloc commented Jan 10, 2014

For reference the Coveralls URL is much the same:

https://coveralls.io/repos/recoilphp/recoil/badge.png?branch=develop

I'll give a patch a go, sure :)

@espadrine I like your example yes! As a personal preference I like including the branch in the path rather than the query parameters.

@espadrine
Copy link
Member

@jmalloc If you want to give it a go, I advise you to change line 11 in server.js so that what we take takes slashes into account, ie, ([^/]+) instead of (.*) in the regexp.

@Krinkle
Copy link

Krinkle commented Jan 11, 2014

Branch names can contain slashes though. Implementing it as a query parameter here, too, might not be a bad idea.

@espadrine
Copy link
Member

@Krinkle I was thinking more like ([^/]+)/([^/]+)/(.+), as in, no slash in the name and repo, but you can have a slash in the branch name.

@espadrine
Copy link
Member

Done with #25.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants