Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve inconsistency with grey colors #56

Closed
antonkomarev opened this issue Sep 17, 2020 · 1 comment
Closed

Resolve inconsistency with grey colors #56

antonkomarev opened this issue Sep 17, 2020 · 1 comment
Labels
enhancement

Comments

@antonkomarev
Copy link
Collaborator

antonkomarev commented Sep 17, 2020 •
edited
Loading

Feature Request

@LifeOfJona noted in antonkomarev/github-profile-views-counter#18 that lightgrey color is not working.

Q A
New Feature yes
RFC no
BC Break no

Summary

This library at this moment has inconsistency in color scheme aliases naming:

  • lightgray exists, but lightgrey missing
  • gray missing, but grey exists

Shields.io supports both variations of word "lightgrey":

Shields.io supports both variations of word "grey":

We should also support lightgrey & gray colors as well.
@antonkomarev antonkomarev changed the title Add lightgrey color Inconsistency with grey colors Sep 17, 2020
@antonkomarev antonkomarev changed the title Inconsistency with grey colors Resolve inconsistency with grey colors Sep 17, 2020
This was referenced Sep 17, 2020
Closed
Merged
@JellyBellyDev
Copy link
Collaborator

Done: #57

Thanks @antonkomarev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JellyBellyDev @antonkomarev