-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI cache on forks #1937
Labels
developer-experience
Dev tooling, test framework, and CI
Comments
Should we close this issue now that you've disabled the cache in #1938 or is there some other way forward? |
I’m hoping they’ll provide a way to fix this. One option is to use workspaces, as folks have noted on that thread. How about we keep it open so we remember to track that thread, and if they don’t fix it within a month, close it out? |
paulmelnikow
added a commit
that referenced
this issue
Jan 21, 2019
It still seems worth using workspace caching to properly tackle #1937, though in the meantime we're wasting time with a useless build. This should cut our total build latency roughly by half.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CircleCI caching stopped working on PRs from forks, which is to say, most of our PRs. This is resulting in failed builds on branches which change
package-lock.json
.The change is a feature, which is a security change that prevents caching on forks. The change makes sense, really, though it's a bit inconvenient for us.
More details on the issue here:
https://discuss.circleci.com/t/saving-cache-stopped-working-warning-skipping-this-step-disabled-in-configuration/24423
I'll open a PR to turn it off for now…
The text was updated successfully, but these errors were encountered: