Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wercker examples, make static examples less error prone #1994

Closed
chris48s opened this issue Aug 28, 2018 · 3 comments · Fixed by #2132
Closed

Fix wercker examples, make static examples less error prone #1994

chris48s opened this issue Aug 28, 2018 · 3 comments · Fixed by #2132
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@chris48s
Copy link
Member

screenshot at 2018-08-28 15 15 15

I think this is probably the only one currently broken on master, but I just made the exact same mistake and didn't notice it in PR #1927 🤦‍♂️

Fix will look like 64974cb

Clearly the way I've done this is a bit fiddly/error prone. I think I need to add some additional error checking to the base class or better assumptions so it is easier to "fall into the pit of success" 🕳️

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Aug 28, 2018
@PyvesB
Copy link
Member

PyvesB commented Aug 30, 2018

I noticed something else that doesn't seem like correct behaviour: when clicking on a badge URL on the homepage, the badge that appears in the window is broken, as it tries to render it using the placeholder URL:
screenshot 123

@paulmelnikow
Copy link
Member

Hmm, what's the expected behavior?

Without having separate fields for the values being filled in, this is a bit tricky.

We could not render a badge until the placeholders are filled in, by searching for colons (which aren't used very often).

The badges that have long had placeholders, like CircleCI, have always had this behavior on that screen.

@PyvesB
Copy link
Member

PyvesB commented Aug 31, 2018

Hmm... I didn't realise it would automatically refresh when you typed. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants