Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wercker examples #2044

Merged
merged 2 commits into from
Sep 2, 2018
Merged

fix wercker examples #2044

merged 2 commits into from
Sep 2, 2018

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Sep 2, 2018

refs #1994

Still need to think about how to improve the base class, but lets fix this one example as a first step.

@shields-ci
Copy link

Warnings
⚠️

This PR modified service code for wercker but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖

✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Sep 2, 2018
PyvesB
PyvesB approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@chris48s chris48s merged commit bca4c05 into badges:master Sep 2, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@dependabot-preview dependabot-preview bot mentioned this pull request Dec 31, 2018
Merged
@BryanLaura BryanLaura mentioned this pull request Jun 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris48s @shields-ci @paulmelnikow @PyvesB