Investigate failing NSP tests

[paulmelnikow]

NSP shut down; maybe the API is gone?

  5) Node Security Platform
       Format '/nsp/npm/:package/:version.:format' where it doesn't exist
         
	[ GET /npm/some-no-exist/1.0.0.json ]:

      AssertionError: expected { name: 'nsp', value: 'invalid' } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "nsp"
      -  "value": "invalid"
      +  "value": "no known vulnerabilities"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  6) Node Security Platform
       Format '/nsp/npm/:package/:version.:format' without vulnerabilities
         
	[ GET /npm/bronze/1.4.0.json ]:

      AssertionError: expected { name: 'nsp', value: 'invalid' } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "nsp"
      -  "value": "invalid"
      +  "value": "no known vulnerabilities"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  7) Node Security Platform
       Format '/nsp/npm/@:scope/:package/:version.:format' where it doesn't exist
         
	[ GET /npm/@some-no-exist/some-no-exist/1.0.0.json ]:

      AssertionError: expected { name: 'nsp', value: 'invalid' } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "nsp"
      -  "value": "invalid"
      +  "value": "no known vulnerabilities"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  8) Node Security Platform
       Format '/nsp/npm/@:scope/:package/:version.:format' without vulnerabilities
         
	[ GET /npm/@cycle/core/1.0.0.json ]:

      AssertionError: expected { name: 'nsp', value: 'invalid' } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "nsp"
      -  "value": "invalid"
      +  "value": "no known vulnerabilities"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

[calebcartwright]

That's funny timing. I was just noticing the nsp service directory in my IDE and wondering if it still worked. The main website @ https://nodesecurity.io appears to have finally been shuttered (redirecting to the npm registry now), and the API endpoint correspondingly seems dead as well https://api.nodesecurity.io/

[calebcartwright]

My assumption is that this badge will need to be deprecated given that the nsp service no longer exists. Is there a standard process for badge deprecation?

Obviously it could be completely removed, but I can see value in a phased removal process as well (first change the badge example docs to indicate deprecation, update the badge to always return something like nsp | deprecated etc.)

[paulmelnikow]

Yup! Here's a recent example of how we handle these: #2352.

[calebcartwright]

Perfect thanks. I can take this one