-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate [nsp] service #2529
Deprecate [nsp] service #2529
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers for updating the docs while working on this
doc/deprecating-badges.md
Outdated
libscore: new Date('2018-09-22'), | ||
imagelayers: new Date('2018-11-18'), | ||
nsp: new Date('2018-12-13'), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of reproducing all this in the docs (it will just drift out-of-sync), lets just link to the file: https://github.com/badges/shields/blob/master/lib/deprecated-services.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
The nsp service was shutdown so deprecating those badges which resolves #2511
Also adds a doc/tutorial for deprecating badges as suggested in #2528