Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus badges with custom repository don't automatically detect Nexus 3 #4639

Closed
2 of 3 tasks
nigredo-tori opened this issue Feb 10, 2020 · 2 comments · Fixed by #4662
Closed
2 of 3 tasks

Nexus badges with custom repository don't automatically detect Nexus 3 #4639

nigredo-tori opened this issue Feb 10, 2020 · 2 comments · Fixed by #4662
Assignees
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs

Comments

@nigredo-tori
Copy link
Contributor

Are you experiencing an issue with...

🪲 Description

Shields created for Nexus 3 servers using the "Sonatype Nexus (repository)" UI say that the artifact is not found. Explicitly setting the nexusVersion parameter fixes the issue - but the parameter itself is not present in the UI.

🔗 Link to the badge

Without nexusVersion: https://img.shields.io/nexus/omni/org.apache.commons/commons-lang3?server=https%3A%2F%2Fnexus.pentaho.org

With nexusVersion: https://img.shields.io/nexus/omni/org.apache.commons/commons-lang3?server=https%3A%2F%2Fnexus.pentaho.org&nexusVersion=3

💡 Possible Solution

Temporary workaround: manually append this to the badge's URL: &nexusVersion=3.

@nigredo-tori nigredo-tori added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Feb 10, 2020
@PyvesB
Copy link
Member

PyvesB commented Feb 15, 2020

Hi @nigredo-tori, thanks for reporting. The fallback logic implemented in #4557 may no be working as expected, will look into it. 😉

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Feb 15, 2020
@PyvesB PyvesB self-assigned this Feb 15, 2020
@PyvesB
Copy link
Member

PyvesB commented Feb 16, 2020

From what I can tell with some further testinh, when hitting a Nexus 3 endpoint with Nexus 2 paths:

  • service/local/lucene/search returns a 400 status code.
  • service/local/artifact/maven/resolve returns a 404 status code.

The fallback logic only covered the first case. Handling the second one in the same way should do the trick, will submit a pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants