Add [Testspace] badges #6162
Merged
Add [Testspace] badges #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
the
service-badge
|
calebcartwright
commented
Feb 9, 2021
| async fetch({ org, project, space }) { | ||
| // https://help.testspace.com/docs/reference/web-api#list-results | ||
| const url = `https://${org}.testspace.com/api/projects/${encodeURIComponent( | ||
| project |
There was a problem hiding this comment.
Project names by default seem to follow the org-name:repo-name pattern so think encoding here is necessary
calebcartwright
commented
Feb 9, 2021
Comment on lines
+48
to
+50
| if (json.length === 0) { | ||
| throw new NotFound({ prettyMessage: 'space not found or results purged' }) | ||
| } |
There was a problem hiding this comment.
spaces can either be specified by a branch name, or an integer id. I'm not sure how likely this would be in practice, but I ran into it after I'd saved a link (which default to the integer id) for a PR run
calebcartwright
commented
Feb 9, 2021
| static route = { | ||
| base: 'testspace', | ||
| pattern: | ||
| ':metric(total|passed|failed|skipped|errored)/:org/:project/:space+', |
There was a problem hiding this comment.
space will often be specified with a branch name, and of course branches in source repos can have /
calebcartwright
force-pushed
the
add-testspace-badges
branch
from
b5d0fb9
to
593a6ac
Compare
chris48s
reviewed
Feb 13, 2021
chris48s
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6077
Opted to pull the common bits into a separate base class and define the badge classes in separate file to get shorter files and slightly simpler tests, but otherwise very similar to our other test result related badge friends (Sonar, AppVeyor, Azure DevOps, Jenkins, etc.)