Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate [DockerBuild] service #6529

Merged
merged 2 commits into from May 23, 2021
Merged

deprecate [DockerBuild] service #6529

merged 2 commits into from May 23, 2021

Conversation

calebcartwright
Copy link
Member

These badges have been broken since at least January of this year (refs #6107), and accordingly the respective service tests have been failing for that long as well. Even when this badge was working it was only geared towards really old repositories that predated the DockerHub merge, and just about every user was forced to use the "newer" DockerCloudBuild anyway.

I see no point in keeping this badge around in a broken state, particularly since there's been zero news or movement from the upstream provider for 4 months now.

Closes #6107

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label May 23, 2021
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6529 May 23, 2021 17:18 Inactive
@shields-ci
Copy link

shields-ci commented May 23, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against 804249f

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, let's deprecate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DockerBuild Service Test Failing
4 participants