Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply 'Migrate request to got (part 1)' #6755

Merged
merged 2 commits into from Jul 11, 2021

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jul 11, 2021

Now that we're working with a more stable baseline, lets try this again.
Maybe memory usage shoots up and we end up reverting it again, but lets give it another go before I dive into another solution.

I think the failing service tests are all down to other issues

Refs #6160
Refs #6277
Refs #4655

@shields-ci
Copy link

shields-ci commented Jul 11, 2021

Warnings
⚠️ This PR modified service code for wercker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for opm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for keybase but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 1e02d1c

@chris48s chris48s added the core Server, BaseService, GitHub auth label Jul 11, 2021
@chris48s chris48s marked this pull request as ready for review July 11, 2021 12:02
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only had a quick look given that this has already been mostly reviewed. Looks ready to go. 👍🏻

@chris48s chris48s changed the title Re-apply 'Migrate request to got (part 1)'; run [*****] Re-apply 'Migrate request to got (part 1)' Jul 11, 2021
@repo-ranger repo-ranger bot merged commit 8983c39 into badges:master Jul 11, 2021
@chris48s
Copy link
Member Author

Cool. I've just deployed this. I'll monitor the metrics over the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants