Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries.io dependent(s)-repos badge doesn't work with go project on GitHub #6779

Open
RubenKelevra opened this issue Jul 18, 2021 · 1 comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs

Comments

@RubenKelevra
Copy link

Are you experiencing an issue with...

shields.io

🐞 Description

I tried to create a dependent- and dependents-repos badge via libraries.io, but the platform go doesn't seem to be supported.

On libraries.io it works fine, though:

https://libraries.io/go/github.com%2Fipfs%2Fgo-ipfs

🔗 Link to the badge

https://img.shields.io/librariesio/dependents/go/github.com%2Fipfs%2Fgo-ipfs

or

https://img.shields.io/librariesio/dependents/go/github.com/ipfs/go-ipfs

💡 Possible Solution

It would be nice if paths like github.com/ipfs/go-ipfs would be processed correctly.

@RubenKelevra RubenKelevra added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Jul 18, 2021
@chris48s
Copy link
Member

I haven't fully investigated this, but I suspect this is partly an easy issue and partly a complicated issue 😄

I think for some of the libraries.io badges we should be able to fix this by switching

pattern: ':platform/:scope(@[^/]+)?/:packageName'

to

pattern: ':platform/:packageName+'

so packageName can contain an arbitrary number of slashes (handling code would need updating to deal with removal of :scope param).

For the routes where there is another optional param after packageName (maybe just just the /release badge?) it is harder. It fundamentally boils down to the same issue as #4559 and #6427 so I think we'd have to create a new base route to solve it and a redirect route for legacy compatibility.

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

2 participants