Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeCodeCamp] Add points badge #6958

Merged
merged 2 commits into from
Aug 28, 2021
Merged

[freeCodeCamp] Add points badge #6958

merged 2 commits into from
Aug 28, 2021

Conversation

SethFalco
Copy link
Contributor

Adds a badge for points a user has on freeCodeCamp. (I'm tempted to say the badge should refer to challenges rather than points, but I'm not 100% sure if completing challenges is the only way to get points.)

I'm unsure about the use of the word "points" in this, as it is indeed "points", but the term is too abstract. Any advice or opinions?

As displayed on a user's profile:
image

As displayed in JSON:

"points": 934,

@shields-ci
Copy link

shields-ci commented Aug 27, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @SethFalco!

Generated by 🚫 dangerJS against beff216

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Aug 28, 2021
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6958 August 28, 2021 02:55 Inactive
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor thing but otherwise LGTM. I think using points is fine as the default label. Users can always set it to something else if they prefer

services/freecodecamp/freecodecamp-points.service.js Outdated Show resolved Hide resolved
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6958 August 28, 2021 16:44 Inactive
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants