Support branches in [Sonar] badges #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
the
service-badge
|
calebcartwright
force-pushed
the
sonar-branches
branch
from
55182c6
to
7855efb
Compare
chris48s
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Sonar support was first added, the product didn't support branch-specific analyses and accordingly it wasn't something our badge routes accounted for as a parameter. Over the years Sonar did add support for branches, which is now available across the full product suite (including the Community and commercial versions of self-hosted SonarQube, and the SaaS SonarCloud) so we should allow consumers of our badges to specify the branch as well