add [PUB] points badge

[G1Joshi]

• Add a badge for PUB to show the points for Dart/Flutter packages and plugins.
• Fix add [PUB] points badge #7917.

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @G1Joshi!

Generated by 🚫 dangerJS against 792c998

[G1Joshi]

This PR depends on #7921.
All tests will pass after merging the above-mentioned PR.

[chris48s]

Is maxPoints always 130? We seem to be doing a bit of a random mix of using maxPoints in some places and hard-coding 130 in others..

[G1Joshi]

Currently, the maximum number of points for the packages or plugins is 130.

[chris48s]

I guess what I am getting at here is:

• If we expect maxPoints can change over time, lets use maxPoints as a variable but loosen the validation. If we validate it as Joi.number().min(130).max(130).required() then if maxPoints ever changes upstream, the badges all break because the validation fails.
• If we're saying it can only ever be 130 then its not really buying us anything for it to be a variable.

[G1Joshi]

Okay, so I have made max points dynamic and added nonNegativeInteger validation. So they will not break even if max points change over time.

[chris48s]

Given there is a ceiling on this one, rather than hard-coding the color we can assign a color based on some kind of scale using floorCount()

shields/services/color-formatters.js

Lines 35 to 47 in 9186f0d

	function floorCount(value, yellow, yellowgreen, green) {
	if (value <= 0) {
	return 'red'
	} else if (value < yellow) {
	return 'yellow'
	} else if (value < yellowgreen) {
	return 'yellowgreen'
	} else if (value < green) {
	return 'green'
	} else {
	return 'brightgreen'
	}
	}

like we do with test coverage, for example:

shields/services/color-formatters.js

Lines 53 to 55 in 9186f0d

	function coveragePercentage(percentage) {
	return floorCount(percentage, 80, 90, 100)
	}

Is there any kind of community norm around what is considered a "good" score we could lean on here? We shouldn't make them all brightgreen even if the score is like 4/130 or whatever

[G1Joshi]

For now, I have added the blue color for pub points as there are no such norms for points.

[chris48s]

With this one it seems like the scale is more esoteric. Clearly bigger numbers are better, but is 20 "Documentation" points and 0 "Platform Support" points exactly the same as 10 "Documentation" points and 10 "Platform Support" points. Maybe lets leave this one as blue/informational.

[G1Joshi]

I have made some changes and assigned colors based on the percentage of their granted points and max points. i.e.

floorCount((grantedPoints / maxPoints) * 100, 40, 60, 80)

[chris48s]

Cheers for working on these

[G1Joshi]

Cheers for working on these

Thanks for your cooperation.