Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch [jitpack] to use latestOk endpoint #8041

Merged
merged 2 commits into from Jun 4, 2022

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jun 3, 2022

closes #8040

As suggested in #8040 (comment) switch to the /latestOk endpoint.

I'm surprised this has never come up before - we've been using /latest for many years. I'm not at all familiar with JitPack but given the behaviour if the latest build is failed seems to be that we get a "not found" response on /latest, I don't think switching to /latestOk represents a meaningful behaviour change.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Jun 3, 2022
@shields-ci
Copy link

shields-ci commented Jun 3, 2022

Warnings
⚠️ This PR modified service code for jitpack but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against d972b7d

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They chose some odd API path names but yes seems to be the right way to go

@repo-ranger repo-ranger bot merged commit 667a609 into badges:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JitPack version badge shows 'not found'
3 participants