Fix invalid rst format when alt or target is present

[abitrolly]

No description provided.

[calebcartwright]

Could you elaborate on the problem you're trying to solve with these proposed changes? If you have an example that reproduces the behavior that'd be great

[abitrolly]

@calebcartwright I've looked for a test and found none, but I guess I could at least post the output, indeed.

The badge generated for fschulze/sqlalchemy_schemadisplay#31 was

.. image:: https://img.shields.io/pypi/v/sqlalchemy_schemadisplay   :alt: PyPI

And that is rendered as a missing image, because GitHub probably translates it to URL. The correct rST markup.

.. image:: https://img.shields.io/pypi/v/sqlalchemy_schemadisplay
   :alt: PyPI

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @abitrolly!

Generated by 🚫 dangerJS against 9ead774

[chris48s]

@calebcartwright This PR does fix a bug. See https://docutils.sourceforge.io/docs/ref/rst/directives.html#image for the correct RST syntax.

@abitrolly The tests for this are in

shields/frontend/lib/generate-image-markup.spec.ts

Lines 49 to 63 in 7d45247

	test(reStructuredText, () => {
	given('https://img.shields.io/badge', undefined, undefined).expect(
	'.. image:: https://img.shields.io/badge'
	)
	given('https://img.shields.io/badge', undefined, 'Example').expect(
	'.. image:: https://img.shields.io/badge :alt: Example'
	)
	given(
	'https://img.shields.io/badge',
	'https://example.com/example',
	'Example'
	).expect(
	'.. image:: https://img.shields.io/badge :alt: Example :target: https://example.com/example'
	)
	})

and will need updating

I've closed and re-opened this to get the CI to run. We do have an issue where sometimes the Circle CI builds don't run for particular PRs - there is some info on this at #8109 I dunno if any of the info in #8109 (comment) are actionable for you. If not, we'll have to do the same again.

[abitrolly]

The .spec.ts extension didn't trigger me that it is a file with tests. Looked like some alien typescript thing to me. Or maybe I was browsing my fork, which was too old to include this file.

Anyway, I think I've fixed tests.

[abitrolly]

Regarding unblocking CircleCI, I don't see this as acceptable for my repos.

[chris48s]

Merging this having pushed 5260a08 - Lets just merge the fix than do another round of back-and-forth over whitespace. Thanks

[abitrolly]

Forgot \n at the ends 🤦 but seems that wouldn't satisfy the linter anyways.

Thanks.