add a missing redirect to [coveralls] #8644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://img.shields.io/coveralls/github/badges/shields
Hi @chris48s,
I noticed that after my last changes to the Coveralls badge (PR #8584 ) there is one redirect missing (for the case without the specified branch).
I added it in this PR.
EDIT:
Tested locally,
http://localhost:8080/coveralls/github/badges/shields
correctly redirects to:
http://localhost:8080/coverallsCoverage/github/badges/shields.svg
Redirect for the option with specified branch also works correctly:
http://localhost:8080/coveralls/github/badges/shields/master ->
http://localhost:8080/coverallsCoverage/github/badges/shields.svg?branch=master